Fix return type of TypeFactoryBase<c10::DynamicType>::get #151803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getBaseType() actually returns a reference. This was causing shared_ptr copies. Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151803
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 414c33e with merge base 6d28d61 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 21, 2025
Closed
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
getBaseType() actually returns a reference. This was causing shared_ptr copies. Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/) [ghstack-poisoned]
This was referenced Apr 21, 2025
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
malfet
approved these changes
Apr 21, 2025
This is specifically changing from a copy of a singleton shared_ptr to a reference to said singleton shared_ptr, so I don't think so. |
swolchok
added
topic: not user facing
getBaseType() actually returns a reference. This was causing shared_ptr copies. Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
|
Starting merge as part of PR stack under #151805 |
|
Starting merge as part of PR stack under #151807 |
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
Pull Request resolved: pytorch/pytorch#151803 getBaseType() actually returns a reference. This was causing shared_ptr copies. ghstack-source-id: 279425431 @exported-using-ghexport Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/)
Skylion007
approved these changes
Apr 22, 2025
…yBase<c10::DynamicType>::get" getBaseType() actually returns a reference. This was causing shared_ptr copies. Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
getBaseType() actually returns a reference. This was causing shared_ptr copies. Differential Revision: [D73376717](https://our.internmc.facebook.com/intern/diff/D73376717/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
|
Starting merge as part of PR stack under #151810 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…()) (#151804) Sadly, I can't just fix text() because that might cause lifetime issues in somebody's code. Differential Revision: [D73376715](https://our.internmc.facebook.com/intern/diff/D73376715/) Pull Request resolved: #151804 Approved by: https://github.com/zou3519, https://github.com/cyyever, https://github.com/Skylion007, https://github.com/malfet ghstack dependencies: #151801, #151802, #151803
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Just some straightforward not-moving-upon-return. Differential Revision: [D73376718](https://our.internmc.facebook.com/intern/diff/D73376718/) Pull Request resolved: #151805 Approved by: https://github.com/malfet, https://github.com/cyyever ghstack dependencies: #151801, #151802, #151803, #151804
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…151806) Looks like we are supposed to be using TypeFactory instead of direct creation everywhere that might run on mobile. Differential Revision: [D73376716](https://our.internmc.facebook.com/intern/diff/D73376716/) Pull Request resolved: #151806 Approved by: https://github.com/Skylion007, https://github.com/iseeyuan ghstack dependencies: #151801, #151802, #151803, #151804, #151805
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Was seeing a small amount of shared_ptr traffic from these. The std::move(text) at the top is just a piggyback. Differential Revision: [D73376720](https://our.internmc.facebook.com/intern/diff/D73376720/) Pull Request resolved: #151807 Approved by: https://github.com/zou3519, https://github.com/cyyever, https://github.com/Skylion007 ghstack dependencies: #151801, #151802, #151803, #151804, #151805, #151806
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2025
) This makes the StringCordView iterator a variant holding either the existing implementation (when there is more than one piece) or a simple `std::string_view::iterator` (when there is only one piece). The latter seems to be significantly cheaper. Differential Revision: [D73379178](https://our.internmc.facebook.com/intern/diff/D73379178/) Pull Request resolved: #151810 Approved by: https://github.com/Skylion007 ghstack dependencies: #151801, #151802, #151803, #151804, #151805, #151806, #151807
|
This pull request was exported from Phabricator. Differential Revision: D73376717 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 25, 2025
We have test_jit.py, but given that I'm working on significant changes to the lexer, it seems nice to have direct C++ tests. (Also, writing the tests caught a pair of related bugs; see the two tests with "Bug" in their name. The rewrite will fix them.) Differential Revision: [D73402367](https://our.internmc.facebook.com/intern/diff/D73402367/) Pull Request resolved: #151849 Approved by: https://github.com/malfet ghstack dependencies: #151801, #151802, #151803, #151804, #151805, #151806, #151807, #151810
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 25, 2025
The trie-based approach was, apparently, not efficient. This incidentally fixes a bug where "not inp" and "is note" were lexed incorrectly; see test_lexer.cpp update. Differential Revision: [D73129443](https://our.internmc.facebook.com/intern/diff/D73129443/) Pull Request resolved: #151850 Approved by: https://github.com/Skylion007 ghstack dependencies: #151801, #151802, #151803, #151804, #151805, #151806, #151807, #151810, #151849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
getBaseType() actually returns a reference. This was causing shared_ptr copies.
Differential Revision: D73376717