Skip to content

[caffe2] Make c10::str works with scoped enum #152705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[caffe2] Make c10::str works with scoped enum #152705

wants to merge 1 commit into from

Conversation

Mizuchi
Copy link
Contributor

@Mizuchi Mizuchi commented May 2, 2025

Test Plan:

buck2 test fbcode//caffe2/c10/test:util_base_tests --fail-fast

Differential Revision: D73872860

@Mizuchi @facebook-github-bot
[caffe2] Make c10::str works with scoped enum
3c56547 
Test Plan:
```
buck2 test fbcode//caffe2/c10/test:util_base_tests --fail-fast
```

Differential Revision: D73872860
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @Mizuchi, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 2, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152705

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 2 Pending

As of commit 3c56547 with merge base 72337bd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73872860

@Mizuchi
Copy link
Contributor Author

Mizuchi commented May 2, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 2, 2025
@Mizuchi Mizuchi closed this May 2, 2025
Mizuchi added a commit to Mizuchi/pytorch that referenced this pull request May 2, 2025
@Mizuchi @facebook-github-bot
[caffe2] Make c10::str works with scoped enum (pytorch#152705)
9a3ef57 
Summary: Pull Request resolved: pytorch#152705

Test Plan:
```
buck2 test fbcode//caffe2/c10/test:util_base_tests --fail-fast
```

Differential Revision: D74087796
@Mizuchi Mizuchi mentioned this pull request May 2, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request May 13, 2025
@Mizuchi @pytorchmergebot
[caffe2] Make c10::str works with scoped enum (#152705) (#152714)
81719eb 
Summary: Pull Request resolved: #152705

Test Plan:
```
buck2 test fbcode//caffe2/c10/test:util_base_tests --fail-fast
```

Differential Revision: D74087796

Pull Request resolved: #152714
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fb-exported topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mizuchi @facebook-github-bot