Skip to content

[EZ][MPS] Enable rsub op #153786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[EZ][MPS] Enable rsub op #153786

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Nothing really to enable, just add it to native functions, TensorIterator abstraction takes care of the rest

@malfet
Update
0f22347 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153786

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0f22347 with merge base 8568dbc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions GitHub Actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@malfet malfet mentioned this pull request May 18, 2025
Closed
@malfet malfet requested review from Skylion007 and dcci May 18, 2025 05:23
@malfet malfet added topic: improvements topic category release notes: mps Release notes category ciflow/mps Run MPS tests (subset of trunk) labels May 18, 2025
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #153787

pytorchmergebot pushed a commit that referenced this pull request May 19, 2025
@malfet @pytorchmergebot
[MPSInductor] Fix conv_transpose channels last (#153787)
694748d 
Regardless of the input layout, transposed convolution always returns contiguous tensor on MPS
Add test to validate that
This fixes torch.compile for SegmentAnything network

Pull Request resolved: #153787
Approved by: https://github.com/cyyever, https://github.com/Skylion007, https://github.com/jansel, https://github.com/dcci
ghstack dependencies: #153786
@github-actions github-actions bot deleted the gh/malfet/340/head branch June 19, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@dcci dcci dcci approved these changes

@cyyever cyyever cyyever approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@malfet @pytorchmergebot @Skylion007 @dcci @cyyever