Skip to content

[2/N] Remove FindPackageHandleStandardArgs.cmake #156559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[2/N] Remove FindPackageHandleStandardArgs.cmake #156559

wants to merge 1 commit into from
+1 −389

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 22, 2025 •
edited
Loading

Following #157188, this PR removes FindPackageHandleStandardArgs.cmake

cc @seemethere @malfet @osalpekar @atalman

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156559

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 657cbf5 with merge base dd0adc9 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 22, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 22, 2025
@cyyever cyyever force-pushed the no_cuda branch 6 times, most recently from 0fd2755 to adb4378 Compare June 22, 2025 21:28
@cyyever cyyever added the module: binaries Anything related to official binaries that we release to users label Jun 23, 2025
@cyyever cyyever requested a review from ezyang June 23, 2025 07:35
@cyyever cyyever added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 23, 2025
@cyyever cyyever marked this pull request as draft June 23, 2025 10:03
@cyyever cyyever force-pushed the no_cuda branch 2 times, most recently from cce9741 to d95de66 Compare July 8, 2025 04:20
@cyyever cyyever changed the title Don't use deprecated CUDA.cmake module [2/N] Don't use deprecated CUDA.cmake module Jul 8, 2025
@cyyever cyyever changed the title [2/N] Don't use deprecated CUDA.cmake module [2/N] Remove FindPackageHandleStandardArgs.cmake Jul 8, 2025
@cyyever cyyever force-pushed the no_cuda branch 3 times, most recently from f020a42 to 80f83c0 Compare July 8, 2025 12:25
@cyyever cyyever marked this pull request as ready for review July 8, 2025 12:25
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 8, 2025
@cyyever cyyever requested a review from Skylion007 July 11, 2025 03:13
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 11, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased no_cuda onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout no_cuda && git pull --rebase)

@cyyever cyyever requested a review from malfet July 11, 2025 10:55
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 11, 2025

The test failures are unrelated.

@cyyever cyyever removed the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jul 22, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 22, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@cyyever @pytorchmergebot
Remove FindPackageHandleStandardArgs.cmake
657cbf5 
Signed-off-by: cyy <cyyever@outlook.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased no_cuda onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout no_cuda && git pull --rebase)

@cyyever cyyever requested a review from albanD July 22, 2025 09:21
albanD
albanD approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 24, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 24, 2025

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request Jul 24, 2025
Open
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@cyyever @yangw-dev
[2/N] Remove FindPackageHandleStandardArgs.cmake (#156559)
6bad920 
Following #157188, this PR removes FindPackageHandleStandardArgs.cmake

Pull Request resolved: #156559
Approved by: https://github.com/albanD
@cyyever cyyever deleted the no_cuda branch September 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: binaries Anything related to official binaries that we release to users open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @pytorchmergebot @albanD @jerryzh168 @pytorchbot