Skip to content

Update TensorPipe submodule #160808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update TensorPipe submodule #160808

wants to merge 3 commits into from

Conversation

johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Aug 16, 2025 •
edited by malfet
Loading

To a commit containing pytorch/tensorpipe#464 that fixes compilation with CUDA-13

Fixes #160104

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160808

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3e86819 with merge base cff6def (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 16, 2025
@johnnynunez
Copy link
Contributor Author

johnnynunez commented Aug 16, 2025 •
edited
Loading

@malfet @nWEIdia could you merge it?

nWEIdia
nWEIdia reviewed Aug 16, 2025
View reviewed changes
Copy link
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please spell out the "last commit" details in the PR?
Is this achieving the same as what @Aidyn-A is trying to do via #159857 ?

nWEIdia
nWEIdia approved these changes Aug 16, 2025
View reviewed changes
Copy link
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the "files changed" view seems sufficient wrt "last commit".

@johnnynunez
Copy link
Contributor Author

Could you please spell out the "last commit" details in the PR? Is this achieving the same as what @Aidyn-A is trying to do via #159857 ?

@malfet merged the fix on tensorpipe to build with cuda 13 pytorch/tensorpipe#464 and it is working for me in Thor

@malfet
Copy link
Contributor

malfet commented Aug 16, 2025

@johnnynunez imo
It would be good to mention commit/PR that unblocks your build in PR description (will edit it later if it passes CI)

P.S. Also it's not fun to be at-mentioned every time someone fork PyTorch

@johnnynunez
Copy link
Contributor Author

@johnnynunez imo It would be good to mention commit/PR that unblocks your build in PR description (will edit it later if it passes CI)

P.S. Also it's not fun to be at-mentioned every time someone fork PyTorch

Got it. Sorry for that

@nWEIdia
Copy link
Collaborator

nWEIdia commented Aug 16, 2025

P.S. Also it's not fun to be at-mentioned every time someone fork PyTorch

Curious to know what caused this and how to avoid it?

@malfet malfet changed the title [NVIDIA] Point tensorpipe to last commit for CUDA 13 Update TensorPipe submodule Aug 17, 2025
@malfet
Copy link
Contributor

malfet commented Aug 17, 2025

@pytorchbot merge -f "Signals seems green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@johnnynunez @can-gaa-hou
Update TensorPipe submodule (pytorch#160808)
9ceed75 
To a commit containing  pytorch/tensorpipe#464 that fixes compilation with CUDA-13

Fixes pytorch#160104
Pull Request resolved: pytorch#160808
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

Assignees
No one assigned
Labels
Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cuda 13 broken
6 participants
@johnnynunez @malfet @nWEIdia @pytorchmergebot @Skylion007 @pytorchbot