Skip to content

fix-unpin-memory-tensor-param #160992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix-unpin-memory-tensor-param #160992

wants to merge 3 commits into from

Conversation

ghostspiders
Copy link
Contributor

@ghostspiders ghostspiders commented Aug 19, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 19, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160992

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 60bd76e with merge base 62db8ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ghostspiders
Copy link
Contributor Author

@pytorchbot label "module: cuda"

@pytorch-bot pytorch-bot bot added the module: cuda Related to torch.cuda, and CUDA support in general label Aug 19, 2025
@Skylion007 Skylion007 requested a review from ngimel August 20, 2025 18:05
@ngimel
Copy link
Collaborator

ngimel commented Aug 20, 2025

Is it possible to add a test to avoid future breakages?

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 20, 2025
@ghostspiders
Copy link
Contributor Author

@ngimel Thank you for your review. I have added the tests, but since I don't have a distributed environment locally to run them, could you please help run the CI to verify the code?

@ghostspiders
Copy link
Contributor Author

@ngimel Thanks for the review. CI is working fine. Can we merge it?

@ngimel
Copy link
Collaborator

ngimel commented Aug 25, 2025

@pytorchbot merge

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025

This PR needs to be approved by an authorized maintainer before merge.

@ngimel
Copy link
Collaborator

ngimel commented Aug 26, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit 19ffdf4 introducing a bug in unpin_memory call
5 participants
@ghostspiders @ngimel @pytorchmergebot @pytorchbot @janeyx99