Replace manual cache in _python_dispatch.get_alias_info with functools.cache #161286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.cache In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. [ghstack-poisoned]
This was referenced Aug 22, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161286
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe95fdf with merge base ffa1ce7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…th functools.cache" In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. [ghstack-poisoned]
This was referenced Aug 22, 2025
…th functools.cache" In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. [ghstack-poisoned]
This was referenced Aug 22, 2025
wconstab
reviewed
Aug 22, 2025
|
|
||
| # Given an OpOverload, returns schema information on it. | ||
| # This is cached for efficiency, since it can involve running torchgen | ||
| @functools.cache |
There was a problem hiding this comment.
for my education- is this purely a "its more idiomatic this way" thing or is this faster too?
There was a problem hiding this comment.
for my education- is this purely a "its more idiomatic this way" thing or is this faster too?
both -- functools.cache does only one lookup. It's pretty neat, check it out
This was referenced Aug 23, 2025
…th functools.cache" In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. [ghstack-poisoned]
This was referenced Aug 25, 2025
wconstab
approved these changes
Aug 26, 2025
This was referenced Aug 26, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Aug 27, 2025
pdesupinski
pushed a commit
that referenced
this pull request
Aug 27, 2025
…s.cache (#161286) In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. Pull Request resolved: #161286 Approved by: https://github.com/wconstab
This was referenced Aug 27, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 29, 2025
…161300) Shouldn't be any generated code impact, just fixing bad practice. Pull Request resolved: #161300 Approved by: https://github.com/wconstab, https://github.com/malfet ghstack dependencies: #161286
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…s.cache (pytorch#161286) In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit. Pull Request resolved: pytorch#161286 Approved by: https://github.com/wconstab
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ytorch#161300) Shouldn't be any generated code impact, just fixing bad practice. Pull Request resolved: pytorch#161300 Approved by: https://github.com/wconstab, https://github.com/malfet ghstack dependencies: pytorch#161286
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#161300) Shouldn't be any generated code impact, just fixing bad practice. Pull Request resolved: pytorch#161300 Approved by: https://github.com/wconstab, https://github.com/malfet ghstack dependencies: pytorch#161286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
is, not ==, to check exact type matches in _python_dispatch #161304In addition to being more code, the manual cache was doing an extra dictionary lookup on each cache hit.