Remove early torch::is_symint call in is_int_or_symint

[swolchok]

Stack from ghstack (oldest at bottom):

• PythonArgParser::symintlist{,Optional} should use SymDimVector #161635
• fastpath type Tensor in THPVariable_NewWithVar #161634
• Avoid redundant PyTuple_GetSize call in _maybe_handle_torch_function #161633
• Use specific Tuple/List APIs instead of PySequence in is_int_or_symint_list #161622
• Remove logger.debug statements in DTensor dispatch #161596
• Add C++ function for torch.distributed.tensor._op_schema.is_view_op #161595
• Don't call check_has_torch_dispatch in THPVariable_NewWithVar if we already know #161591
• Add torch.Tensor._make_dtensor to accelerate DTensor.__new__ further #161590
• Add C++ function to accelerate DTensor.__new__ #161588
• Add inline fast paths for SymInt operators #161586
• Outline SymInt::maybe_as_int_slow_path #161466
• PythonArgs::toBool: order cheap mutually exclusive checks first #161455
• -> Remove early torch::is_symint call in is_int_or_symint #161438
• Check for Index before Tensors in is_int_or_symint #161433
• Stop trying to intern arguments in PyObject_FastGetAttrString #161432
• Fix accidental copy in pushPyOutToStack #161329
• Avoid double hash lookup in torch._library.simple_registry #161328
• Improve assert perf in _python_dispatch._correct_storage_aliasing #161317
• Fix pybind enum efficiency issue in return_and_correct_aliasing #161315
• Optimize _python_dispatch.return_and_correct_aliasing.get_write_alias #161308
• Use is, not ==, to check exact type matches in _python_dispatch #161304
• Stop accessing func._schema in _python_dispatch.correct_storage_aliasing #161292
• Fix forced copying def_property_readonly for FunctionSchema & friends #161301
• Fix non-const reference arguments in torch/csrc/jit/python/init.cpp #161300
• Replace manual cache in _python_dispatch.get_alias_info with functools.cache #161286

If I am reading THPUtils_checkIndex correctly, it already checks torch::is_symint before hitting index or int.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161438

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 275b500 with merge base ffa1ce7 ():

NEW FAILURES - The following jobs have failed:

• pull / linux-jammy-py3.10-clang18-asan / test (default, 3, 6, lf.linux.4xlarge) (gh)
  profiler/test_profiler_tree.py::TestProfilerTree::test_profiler_experimental_tree_with_stack_and_torch_dispatch
• pull / linux-jammy-py3.10-clang18-asan / test (default, 4, 6, lf.linux.4xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.13-clang12 / test (crossref, 2, 2, lf.linux.2xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.13-clang12 / test (default, 4, 5, lf.linux.4xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.9-clang12 / test (crossref, 2, 2, lf.linux.2xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.9-clang12 / test (default, 4, 5, lf.linux.4xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.9-clang12 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, lf.linux.2xlarge) (gh)
  test_proxy_tensor.py::TestSymbolicTracing::test_fake_tensor_as_size
• pull / linux-jammy-py3.9-gcc11 / test (default, 5, 5, lf.linux.2xlarge) (gh)
  profiler/test_profiler_tree.py::TestProfilerTree::test_profiler_experimental_tree_with_stack_and_torch_dispatch

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[swolchok]

abandoning; I think we want to add a check for plain old int, not delete checks