Skip to content

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 22, 2025

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161320

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 34bccd0 with merge base ac7b4e7 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 22, 2025
ghstack-source-id: 691b9f9
Pull Request resolved: #161320
mikaylagawarecki added a commit that referenced this pull request Aug 22, 2025
ghstack-source-id: 5ed00f0
Pull Request resolved: #161320
Copy link
Contributor

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.


Caused by:

mikaylagawarecki added a commit that referenced this pull request Aug 23, 2025
ghstack-source-id: b3f7fdf
Pull Request resolved: #161320
return get_in_at_parallel();
}

inline ParallelGuard(bool state) : previous_state_(is_enabled()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can ctor can be remove an invocation of the reference getter by using std::exchange

return get_in_at_parallel();
}

inline ParallelGuard(bool state) : previous_state_(is_enabled()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous_state_(std::exchange(get_in_at_parallel(), state)) {}

mikaylagawarecki added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: e9a7389
Pull Request resolved: #161320
mikaylagawarecki added a commit that referenced this pull request Oct 6, 2025
ghstack-source-id: 33fb487
Pull Request resolved: #161320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants