[EZ] Fix UP041 violations #163648
Closed
[EZ] Fix UP041 violations #163648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163648
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 24 PendingAs of commit f529b4a with merge base 649ceda ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 23, 2025
cyyever
approved these changes
Sep 23, 2025
Skylion007
approved these changes
Sep 23, 2025
|
Starting merge as part of PR stack under #163649 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 23, 2025
As it has been removed, see https://docs.astral.sh/ruff/rules/non-pep604-isinstance/ Pull Request resolved: #163649 Approved by: https://github.com/Skylion007 ghstack dependencies: #163648
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 23, 2025
Pull Request resolved: #163653 Approved by: https://github.com/jansel ghstack dependencies: #163648, #163649
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
I.e. use `TimeoutError` instead of `socket.timeout` Pull Request resolved: pytorch#163648 Approved by: https://github.com/cyyever, https://github.com/Skylion007
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
As it has been removed, see https://docs.astral.sh/ruff/rules/non-pep604-isinstance/ Pull Request resolved: pytorch#163649 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#163648
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Pull Request resolved: pytorch#163653 Approved by: https://github.com/jansel ghstack dependencies: pytorch#163648, pytorch#163649
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Pull Request resolved: #163653 Approved by: https://github.com/jansel ghstack dependencies: #163648, #163649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I.e. use
TimeoutErrorinstead ofsocket.timeout