[iOS] add benchmark code to iOS TestApp #28405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xta0
added
the
module: ios
|
Awesome, thank you for working on this Tao. |
AshkanAliabadi
approved these changes
Oct 22, 2019
xta0
added a commit
that referenced
this pull request
Oct 22, 2019
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
xta0
added a commit
that referenced
this pull request
Oct 23, 2019
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
xta0
added a commit
that referenced
this pull request
Oct 23, 2019
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2019
Summary: Pull Request resolved: #28469 ### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky. Test Plan: Imported from OSS Differential Revision: D18097248 Pulled By: xta0 fbshipit-source-id: 6f9d1275a07aecae21afd81d5e90a89a75d0270f
xta0
added a commit
that referenced
this pull request
Oct 24, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 24, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 25, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 25, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 25, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 25, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added a commit
that referenced
this pull request
Oct 25, 2019
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2019
Summary: Pull Request resolved: #28622 ### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky. Test Plan: Imported from OSS Differential Revision: D18156178 Pulled By: xta0 fbshipit-source-id: cd7ba8d87bf26db885262888b9d6a5fd072309d1
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28405 ### Summary As discussed with AshkanAliabadi and ljk53, the iOS TestApp will share the same benchmark code with Android's speed_benchmark_torch.cpp. This PR is the first part which contains the Objective-C++ code. The second PR will include the scripts to setup and run the benchmark project. The third PR will include scripts that can automate the whole "build - test - install" process. There are many ways to run the benchmark project. The easiest way is to use cocoapods. Simply run `pod install`. However, that will pull the 1.3 binary which is not what we want, but we can still use this approach to test the benchmark code. The second PR will contain scripts to run custom builds that we can tweak. ### Test Plan - Don't break any existing CI jobs (except for those flaky ones) Test Plan: Imported from OSS Differential Revision: D18064187 Pulled By: xta0 fbshipit-source-id: 4cfbb83c045803d8b24bf6d2c110a55871d22962
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28469 ### Summary As described [here](pytorch#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky. Test Plan: Imported from OSS Differential Revision: D18097248 Pulled By: xta0 fbshipit-source-id: 6f9d1275a07aecae21afd81d5e90a89a75d0270f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
As discussed with @AshkanAliabadi and @ljk53, the iOS TestApp will share the same benchmark code with Android's speed_benchmark_torch.cpp. This PR is the first part which contains the Objective-C++ code.
The second PR will include the scripts to setup and run the benchmark project. The third PR will include scripts that can automate the whole "build - test - install" process.
There are many ways to run the benchmark project. The easiest way is to use cocoapods. Simply run
pod install. However, that will pull the 1.3 binary which is not what we want, but we can still use this approach to test the benchmark code. The second PR will contain scripts to run custom builds that we can tweak.Test Plan
Differential Revision: D18064187