[iOS] Automation scripts for perf testing #28622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
xta0
added
the
module: ios
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
ljk53
reviewed
Oct 25, 2019
| @@ -61,16 +69,14 @@ + (void)benchmarkWithModel:(NSString*)modelPath { | |||
| if (FLAGS_print_output) { | |||
| std::cout << module.forward(inputs) << std::endl; | |||
There was a problem hiding this comment.
change this to UI_LOG as well? or just remove this? how do we support gflags in iOS test app?
There was a problem hiding this comment.
Right now, all the gflag values are hardcoded. I'm thinking about using a JSON file to make it configurable.
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
|
@ljk53 Refactored the code a lil bit, now we can set the gflag parameters via a |
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
### Summary As discussed in #28405 , this is the third PR. The`bootstrap.sh` script is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup ) All you need to do is run ```shell ./bootstrap -t ${TEAM_ID} -p ${PROFILE} ``` The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen. ### Test plan Don't break any CI jobs unless they're flaky.
ljk53
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
As discussed in #28405 , this is the third PR. The
bootstrap.shscript is mainly for those who want to do perf on iOS but don't want to touch XCode or any iOS code. But it does require you have valid iOS dev credentials installed on your machine. (You can easily acquire those stuff from any experienced iOS developers. Takes only 5 mins to setup )All you need to do is run
The testing app will be automatically installed on your device. The log of the benchmark function will be displayed on the screen.
Test plan
Don't break any CI jobs unless they're flaky.
Differential Revision: D18156178