[quant][graphmode][fx] Add support for conv module #43285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Aug 19, 2020
💊 CI failures summary and remediationsAs of commit dabe528 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23221733](https://our.internmc.facebook.com/intern/diff/D23221733) [ghstack-poisoned]
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23221733](https://our.internmc.facebook.com/intern/diff/D23221733) [ghstack-poisoned]
This was referenced Aug 20, 2020
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23221733](https://our.internmc.facebook.com/intern/diff/D23221733) [ghstack-poisoned]
vkuzo
approved these changes
Aug 20, 2020
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23221733](https://our.internmc.facebook.com/intern/diff/D23221733) [ghstack-poisoned]
Summary: Porting op tests from test_quantize_jit.py Test Plan: TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23221733](https://our.internmc.facebook.com/intern/diff/D23221733) [ghstack-poisoned]
This was referenced Aug 21, 2020
| raise Exception("unhandled conv type:", type(self.conv)) | ||
| quantized = qconv.from_float(self.conv) | ||
| # TODO: make the mapping configurable? | ||
| assert type(self.conv) in DEFAULT_MODULE_MAPPING, \ |
There was a problem hiding this comment.
This is a looser check than the previous check which was checking for specific module classes. Is this sufficient?
There was a problem hiding this comment.
yeah it is equivalent, the check on the left side can be represented by the mapping.
|
This pull request has been merged in 9984d33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Porting op tests from test_quantize_jit.py
Test Plan:
TestQuantizeFxOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23221733