[quant][grapphmode][fx][test][refactor] Refactor quantized add test #43372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: So that adding more binary op tests are easier Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Aug 21, 2020
💊 CI failures summary and remediationsAs of commit 0515808 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
z-a-f
approved these changes
Aug 21, 2020
Comment on lines
+229
to
238
| # class NonQuantizedOp(torch.nn.Module): | ||
| # def __init__(self, is_inplace, is_scalar): | ||
| # super(NonQuantizedOp, self).__init__() | ||
| # self.is_scalar = is_scalar | ||
| # self.op = ibinary_op if is_inplace else binary_op | ||
|
|
||
| # def forward(self, x, y): | ||
| # return x + y | ||
|
|
||
| # class NonQuantizedInplaceAdd(torch.nn.Module): | ||
| # def __init__(self): | ||
| # super(NonQuantizedInplaceAdd, self).__init__() | ||
|
|
||
| # def forward(self, x, y): | ||
| # x += y | ||
| # y = 3 if self.is_scalar else y | ||
| # x = self.op(x, y) | ||
| # return x |
There was a problem hiding this comment.
we'll either remove or enable this after we decide what to do in this case
… add test" Summary: So that adding more binary op tests are easier Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23257046](https://our.internmc.facebook.com/intern/diff/D23257046) [ghstack-poisoned]
|
This pull request has been merged in ff454cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
So that adding more binary op tests are easier
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23257046