Delete TypeDefault call code generation logic in VariableType #47000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a new invariant that emit_body is only ever called when strategy is 'use_derived', which means we can delete a bunch of code. This removes the last use of TypeXXX.h headers. Note that this change makes sense, as the TypeDefault entries are registered as Math entries, which means they automatically populate Autograd (and we no longer have to register them ourselves). Ailing did all the hard work, this is just the payoff. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Oct 28, 2020
ezyang
added a commit
that referenced
this pull request
Oct 28, 2020
There is a new invariant that emit_body is only ever called when strategy is 'use_derived', which means we can delete a bunch of code. This removes the last use of TypeXXX.h headers. Note that this change makes sense, as the TypeDefault entries are registered as Math entries, which means they automatically populate Autograd (and we no longer have to register them ourselves). Ailing did all the hard work, this is just the payoff. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 95da6a3 Pull Request resolved: #47000
ljk53
approved these changes
Oct 28, 2020
This was referenced Oct 28, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/860/base #47000 +/- ##
======================================================
- Coverage 68.95% 68.95% -0.01%
======================================================
Files 434 434
Lines 56248 56248
======================================================
- Hits 38786 38785 -1
- Misses 17462 17463 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There is a new invariant that emit_body is only ever called when
strategy is 'use_derived', which means we can delete a bunch of code.
This removes the last use of TypeXXX.h headers.
Note that this change makes sense, as the TypeDefault entries are
registered as Math entries, which means they automatically populate
Autograd (and we no longer have to register them ourselves). Ailing
did all the hard work, this is just the payoff.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D24596584