-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Delete Vulkan from code generator. #46938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It turns out that after #42194 landed we no longer actually generate any registrations into this file. That means it's completely unnecessary. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 501ceda (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
It turns out that after #42194 landed we no longer actually generate any registrations into this file. That means it's completely unnecessary. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518) [ghstack-poisoned]
It turns out that after #42194 landed we no longer actually generate any registrations into this file. That means it's completely unnecessary. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518) [ghstack-poisoned]
It turns out that after #42194 landed we no longer actually generate any registrations into this file. That means it's completely unnecessary. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518) [ghstack-poisoned]
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938. Pull Request resolved: #76080 Approved by: https://github.com/albanD
Summary: '--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938. Pull Request resolved: #76080 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bc9bba9b439f50d74d1fd81882dc62c98ab67d85 Reviewed By: osalpekar Differential Revision: D35938179 fbshipit-source-id: adea7c1d4d23c5b0f9aa30bb3a99606cc566ef7c
Stack from ghstack:
It turns out that after #42194
landed we no longer actually generate any registrations into this
file. That means it's completely unnecessary.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D24573518