-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Enabled BFloat16 support for cumsum, logcumsumexp, cumprod, cummin & cummax on CUDA #57904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 2bd0d34 (more details on the Dr. CI page):
10 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #57904 +/- ##
==========================================
+ Coverage 76.44% 76.81% +0.37%
==========================================
Files 1990 1984 -6
Lines 199690 197144 -2546
==========================================
- Hits 152651 151446 -1205
+ Misses 47039 45698 -1341 |
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Test errors are real, this PR doesn't enable cummin/cummax |
Sorry, @ngimel, I hadn't looked at the CI results until now. I'll take a look & will request you again after fixing the issue. Thanks! |
Hello @ngimel, they were previously enabled & all the CI checks had passed, but GitHub had disabled them again when you merged the master branch of the main repo with this PR - GitHub probably did this because |
Hello @ngimel, the current CI failures are unrelated. |
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Enabled BFloat16 support for
cumsum
,logcumsumexp
,cumprod
,cummin
&cummax
on CUDA