Skip to content

Conversation

imaginary-person
Copy link
Contributor

Enabled BFloat16 support for cumsum, logcumsumexp, cumprod, cummin & cummax on CUDA

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2021

💊 CI failures summary and remediations

As of commit 2bd0d34 (more details on the Dr. CI page):


  • 10/10 failures introduced in this PR

10 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_ios_12_0_0_x86_64_full_jit_build Spin up environment 🔁 rerun
CircleCI pytorch_ios_12_0_0_x86_64_build Spin up environment 🔁 rerun
CircleCI pytorch_macos_10_13_py3_build Spin up environment 🔁 rerun
CircleCI pytorch_ios_12_0_0_arm64_metal_build Spin up environment 🔁 rerun
CircleCI pytorch_macos_10_15_py3_build Spin up environment 🔁 rerun
CircleCI pytorch_windows_vs2019_py36_cpu_build Spin up environment 🔁 rerun
CircleCI pytorch_ios_12_0_0_arm64_custom_build Spin up environment 🔁 rerun
CircleCI pytorch_ios_12_0_0_arm64_full_jit_build Spin up environment 🔁 rerun
CircleCI pytorch_windows_vs2019_py36_cuda11.1_build Spin up environment 🔁 rerun
CircleCI pytorch_ios_12_0_0_arm64_build Spin up environment 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@imaginary-person imaginary-person marked this pull request as draft May 9, 2021 01:58
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #57904 (a0a6279) into master (ccd7141) will increase coverage by 0.37%.
The diff coverage is n/a.

❗ Current head a0a6279 differs from pull request most recent head 5eceda8. Consider uploading reports for the commit 5eceda8 to get more accurate results

@@            Coverage Diff             @@
##           master   #57904      +/-   ##
==========================================
+ Coverage   76.44%   76.81%   +0.37%     
==========================================
  Files        1990     1984       -6     
  Lines      199690   197144    -2546     
==========================================
- Hits       152651   151446    -1205     
+ Misses      47039    45698    -1341     

@imaginary-person imaginary-person marked this pull request as ready for review May 10, 2021 19:52
@bdhirsh bdhirsh requested a review from ngimel May 10, 2021 22:04
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 10, 2021
@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented May 20, 2021

Test errors are real, this PR doesn't enable cummin/cummax

@imaginary-person
Copy link
Contributor Author

Sorry, @ngimel, I hadn't looked at the CI results until now. I'll take a look & will request you again after fixing the issue. Thanks!

@imaginary-person
Copy link
Contributor Author

imaginary-person commented May 20, 2021

Hello @ngimel, they were previously enabled & all the CI checks had passed, but GitHub had disabled them again when you merged the master branch of the main repo with this PR -

5eceda8

GitHub probably did this because checkSameGPU's syntax has changed since. However, it wasn't supposed to modify the next line as well, as it usually doesn't modify lines that are revised in a PR, without notifying about conflicts. So, maybe this is a bug on GitHub.com.

@imaginary-person
Copy link
Contributor Author

Hello @ngimel, the current CI failures are unrelated.
I had re-enabled cummin & cummax for BFloat16. Thank you!

@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in c5a1f04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants