-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[Profiler] trace verbose=false by default #86263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86263
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ab3af7c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D40092377 |
Summary: Pull Request resolved: pytorch#86263 - Added config option to remove 'Call stack' field from trace file (pytorch#84982) - Change default value to `false` Test Plan: - `experimental_config=_ExperimentalConfig(verbose=true),` will add 'Call stack' field back in the trace file. - CI tests Differential Revision: D40092377 fbshipit-source-id: 8bd7984ee8b8502bbaa2cfc587c88b6c63f6a7ac
This pull request was exported from Phabricator. Differential Revision: D40092377 |
fe03ece
to
ab3af7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reviewed internally.
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
@pytorchbot successfully started a merge job. Check the current status here. |
Hey @slgong-fb. |
Summary: Pull Request resolved: #86263 - Added config option to remove 'Call stack' field from trace file (#84982) - Change default value to `false` Test Plan: - `experimental_config=_ExperimentalConfig(verbose=true),` will add 'Call stack' field back in the trace file. - CI tests Reviewed By: aaronenyeshi Differential Revision: D40092377 fbshipit-source-id: 53bf0dac49032d6f04397f0ac48dca4674ad03a4
Summary:
false
Test Plan:
experimental_config=_ExperimentalConfig(verbose=true),
will add 'Call stack' field back in the trace file.Differential Revision: D40092377