Skip to content

Conversation

slgong-fb
Copy link
Contributor

Summary:

Test Plan:

  • experimental_config=_ExperimentalConfig(verbose=true), will add 'Call stack' field back in the trace file.
  • CI tests

Differential Revision: D40092377

@slgong-fb slgong-fb requested a review from robieta as a code owner October 5, 2022 07:21
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86263

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ab3af7c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40092377

Summary:
Pull Request resolved: pytorch#86263

- Added config option to remove 'Call stack' field from trace file (pytorch#84982)
- Change default value to `false`

Test Plan:
- `experimental_config=_ExperimentalConfig(verbose=true),` will add 'Call stack' field back in the trace file.
- CI tests

Differential Revision: D40092377

fbshipit-source-id: 8bd7984ee8b8502bbaa2cfc587c88b6c63f6a7ac
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40092377

Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed internally.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2022
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Hey @slgong-fb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 6, 2022
Summary:
Pull Request resolved: #86263

- Added config option to remove 'Call stack' field from trace file (#84982)
- Change default value to `false`

Test Plan:
- `experimental_config=_ExperimentalConfig(verbose=true),` will add 'Call stack' field back in the trace file.
- CI tests

Reviewed By: aaronenyeshi

Differential Revision: D40092377

fbshipit-source-id: 53bf0dac49032d6f04397f0ac48dca4674ad03a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants