[ONNX] Fix triu/tril export with diagonal input (#86843) #86925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86925
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f77be0c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
|
@pytorchbot rebase -b release/1.13 |
|
@pytorchbot successfully started a rebase job. Check the current status here |
Investigation with @thiagocrepaldi discovered this bug with triu/tril export when `diagonal` is passed in as input. Previously assumption was made that `diagonal` is always provided a constant value. Pull Request resolved: #86843 Approved by: https://github.com/thiagocrepaldi, https://github.com/abock
|
Successfully rebased |
pytorchmergebot
force-pushed
the
bowbao/release1.13/cp4
branch
from
84a64e2 to
f77be0c
Compare
malfet
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation with @thiagocrepaldi discovered this bug with triu/tril export when
diagonalis passed in as input. Previously assumption was made thatdiagonalis always provided a constant value.Pull Request resolved: #86843
Approved by: https://github.com/thiagocrepaldi, https://github.com/abock
Fixes #ISSUE_NUMBER