Skip to content

Make meshgrid support symbolic shapes #93075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Make meshgrid support symbolic shapes #93075

wants to merge 5 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jan 26, 2023 •
edited by pytorch-bot bot
Loading

@ezyang
Make meshgrid support symbolic shapes
faabada 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93075

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 2 Pending

As of commit 7df9cf6:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Update on "Make meshgrid support symbolic shapes"
6b4aa26 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category ciflow/trunk Trigger trunk jobs on your pull request labels Jan 26, 2023
Skylion007
Skylion007 reviewed Jan 26, 2023
View reviewed changes
@ezyang
Update on "Make meshgrid support symbolic shapes"
3f3c270 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@github-actions github-actions bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jan 26, 2023
@ezyang
Update on "Make meshgrid support symbolic shapes"
6a5e31e 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen

[ghstack-poisoned]
@ezyang ezyang added the keep-going Don't stop on first failure, keep running tests until the end label Jan 26, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator

is the mkl change intended?

@ezyang
Copy link
Contributor Author

ezyang commented Jan 26, 2023

No, gfd lol

@ezyang
Update on "Make meshgrid support symbolic shapes"
7df9cf6 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Jan 26, 2023

@pytorchbot merge -f "had clean ci prev only fix submodule"

ezyang added a commit that referenced this pull request Jan 26, 2023
@ezyang
Make meshgrid support symbolic shapes
c1704f5 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 591f3b2
Pull Request resolved: #93075
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@ezyang
Copy link
Contributor Author

ezyang commented Jan 26, 2023

@pytorchbot merge -f "had clean ci, submod change only"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1744/head branch June 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration release notes: composability release notes category topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezyang @pytorchmergebot @Skylion007