Skip to content

[inductor] Refactor IR printing #96024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[inductor] Refactor IR printing #96024

wants to merge 3 commits into from

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Mar 4, 2023 •
edited
Loading

@jansel
[inductor] Refactor IR printing
4881251 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

[ghstack-poisoned]
@jansel jansel mentioned this pull request Mar 4, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96024

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1cf421f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel requested a review from desertfire March 4, 2023 04:06
@jansel
Update on "[inductor] Refactor IR printing"
5bbbc76 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jansel added a commit that referenced this pull request Mar 4, 2023
@jansel
[inductor] Refactor IR printing
8496b7d 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

ghstack-source-id: b4425b0
Pull Request resolved: #96024
Skylion007
Skylion007 reviewed Mar 4, 2023
View reviewed changes
torch/_inductor/virtualized.py
for name, arg in zip(names, args):
if arg:
lhs = ", ".join(
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a generator instead of a list comprehension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters since this list will be <10 elements.

@jansel jansel added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Mar 4, 2023
@jansel
Update on "[inductor] Refactor IR printing"
1cf421f 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jansel added a commit that referenced this pull request Mar 6, 2023
@jansel
[inductor] Refactor IR printing
8daed65 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

ghstack-source-id: 9ad1914
Pull Request resolved: #96024
@jansel
Copy link
Contributor Author

jansel commented Mar 7, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@davidberard98
Copy link
Contributor

@jansel I bisected a memory compression regression on Super_SloMo (0.967 -> 0.8615) to this PR, can you take a look?

@ngimel
Copy link
Collaborator

ngimel commented Mar 10, 2023

cc @desertfire, somehow we didn't catch this memory compression regression in CI, perhaps makes sense to also add SuperSloMo (if it's memory compression is stable enough)

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@jansel @cyyever
[inductor] Refactor IR printing (#96024)
b074b4c 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

Pull Request resolved: pytorch/pytorch#96024
Approved by: https://github.com/ngimel
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@jansel @cyyever
[inductor] Refactor IR printing (#96024)
04552cc 
Reland #95567 part 2.  The previous version of this had a bug which that
added test triggers.

Pull Request resolved: pytorch/pytorch#96024
Approved by: https://github.com/ngimel
@jansel
Copy link
Contributor Author

jansel commented Mar 12, 2023

@jansel I bisected a memory compression regression on Super_SloMo (0.967 -> 0.8615) to this PR, can you take a look?

Weird. Perhaps we need to increase realize_bytes_threshold because the strings are slightly longer now.

ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[inductor] Refactor IR printing (pytorch#96024)
bd36a7f 
Reland pytorch#95567 part 2.  The previous version of this had a bug which that
added test triggers.

Pull Request resolved: pytorch#96024
Approved by: https://github.com/ngimel
@facebook-github-bot facebook-github-bot deleted the gh/jansel/65/head branch June 8, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@ngimel ngimel ngimel approved these changes

@desertfire desertfire Awaiting requested review from desertfire

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jansel @pytorchmergebot @davidberard98 @ngimel @Skylion007