Skip to content

[BugFix]: joining processes when they're done #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 6, 2022
Merged

[BugFix]: joining processes when they're done #311

merged 13 commits into from
Aug 6, 2022

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Jul 20, 2022 •
edited
Loading

Description

Some mp tests do not join processes at the end of the function call. This PR solves this by calling process.join when needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2022
@vmoens vmoens marked this pull request as ready for review July 20, 2022 18:10
@vmoens vmoens added the bug Something isn't working label Jul 25, 2022
vmoens added 3 commits July 26, 2022 18:07
@vmoens
amend
f69eff0
@vmoens
Merge branch 'main' into joining_fix
620a893 
# Conflicts:
#	.circleci/unittest/linux/scripts/setup_env.sh
#	.circleci/unittest/linux_stable/scripts/setup_env.sh
@vmoens
amend
6b38c73
@vmoens vmoens merged commit 27b1c50 into main Aug 6, 2022
@vmoens vmoens deleted the joining_fix branch August 6, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot