Skip to content

[BugFix]: joining processes when they're done #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 6, 2022
Merged

[BugFix]: joining processes when they're done #311

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9fd73af
amend
vmoens Jul 20, 2022
35fd717
Merge branch 'main' into joining_fix
vmoens Jul 20, 2022
0a4803e
amend
vmoens Jul 20, 2022
b32d79b
amend
vmoens Jul 20, 2022
24a6167
amend
vmoens Jul 21, 2022
53ea9da
amend
vmoens Jul 21, 2022
331b03e
amend
vmoens Jul 21, 2022
e1bca5b
amend
vmoens Jul 21, 2022
45a715c
install all
vmoens Jul 23, 2022
8b1d204
restart conda
vmoens Jul 25, 2022
f69eff0
amend
vmoens Jul 26, 2022
620a893
Merge branch 'main' into joining_fix
vmoens Aug 6, 2022
6b38c73
amend
vmoens Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# LICENSE file in the root directory of this source tree.
import argparse
from copy import copy
from time import sleep

import pytest
import torch
Expand Down Expand Up @@ -154,6 +155,8 @@ def test_vecnorm_parallel(nprc):
for idx in range(nprc):
queues[idx][1].put(msg)
del queues
for p in prcs:
p.join()


def _test_vecnorm_subproc_auto(idx, make_env, queue_out: mp.Queue, queue_in: mp.Queue):
Expand Down Expand Up @@ -219,6 +222,9 @@ def test_vecnorm_parallel_auto(nprc):
for idx in range(nprc):
queues[idx][1].put(msg)

sleep(0.01) # Further fix for flacky test: vecnorm should have a locking
# mechanism

obs_sum = td.get("next_observation_sum").clone()
obs_ssq = td.get("next_observation_ssq").clone()
obs_count = td.get("next_observation_count").clone()
Expand Down