Update Provenance Tracking Name #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertfire
reviewed
May 22, 2025
| // Generate HTML for each directory name | ||
| for directory_name in &directory_names { | ||
| let pre_grad_graph_content = | ||
| get_file_content(&output, "inductor_pre_grad_graph", directory_name); |
There was a problem hiding this comment.
Need to keep the old names for backward compatibility.
There was a problem hiding this comment.
Need to keep the old names for backward compatibility.
@desertfire I'll add back the file name to be BC. But I'm updating the doc to say it's only compatible with the nightly build in pytorch/pytorch#154062 because it may still not be compatible with earlier versions of PyTorch (e.g. a few months ago).
There was a problem hiding this comment.
@desertfire added back in PR #111
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 23, 2025
Summary: Update the doc to reflect the changes in https://github.com/pytorch/pytorch/pull/153584/files#diff-e0cdb58c0f84f56f20c5433339b6d83c470dcde47847e2328effea6bedd4cd27 and meta-pytorch/tlparse#110 Test Plan: CI Differential Revision: D75155981 Pull Request resolved: #154062 Approved by: https://github.com/svekars, https://github.com/desertfire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the file names used for provenance tracking due to changes in https://github.com/pytorch/pytorch/pull/153584/files#diff-e0cdb58c0f84f56f20c5433339b6d83c470dcde47847e2328effea6bedd4cd27
Additional changes: