Skip to content

Conversation

NicolasHug
Copy link
Member

Thanks to @traversaro , Windows GPU support is available via conda-forge.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 10, 2025
Comment on lines -165 to -167
If you are building FFmpeg from source you can follow Nvidia's guide to
configuring and installing FFmpeg with NVDEC support
[here](https://docs.nvidia.com/video-technologies/video-codec-sdk/12.0/ffmpeg-with-nvidia-gpu/index.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by, I don't want to bother readers about installing FFmpeg from source, they shouldn't need to and it shouldn't be in the "entry point" install instructions anyway.

README.md Outdated
Note that without passing in the `--index-url` parameter, `pip` installs
the CPU-only version of TorchCodec.
```bash
conda install torchcodec -c conda-forge
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
conda install torchcodec -c conda-forge
conda install torchcodec -c conda-forge

this should indeed install torchcodec with cuda support on a machine with cuda support, but it may silently install the cpu version on a machine without cuda support. If you want to make sure that the cuda version is installed, and an error is printed in case it is not possible to install, you need to:

Suggested change
conda install torchcodec -c conda-forge
conda install torchcodec=*=*cuda* -c conda-forge

@traversaro
Copy link
Collaborator

As a meta-comment on this, I do not monitor all the issues in the torchcodec repo, so if there are users experiencing problems with the conda-forge packages, feel free to ping me or to redirect them to open an issue at https://github.com/conda-forge/torchcodec-feedstock/issues .

@traversaro
Copy link
Collaborator

traversaro commented Sep 10, 2025

Also, I am not sure if the instructions in the current form actually works. In point 1, it is described how to install PyTorch with pip, but that would not work out of the box (due to different ABIs) with the conda-forge torchcodec package. If one wants to use CUDA-enabled torchcodec on Windows, it can simply create a new conda environment with:

conda create -n torchcodeccuda -c conda-forge torchcodec=*=*cuda*

and this command will automatically install the approprite cuda, ffmpeg and pytorch version via conda-forge.

@scotts
Copy link
Contributor

scotts commented Sep 10, 2025

@traversaro, thank you for making this happen!

@traversaro
Copy link
Collaborator

@traversaro, thank you for making this happen!

Thanks for for all the work on torchcodec, I actually did not changed anything for the test to pass on Windows+CUDA, everything worked out of the box on the first try.

@NicolasHug NicolasHug merged commit ab10088 into pytorch:main Sep 10, 2025
47 checks passed
@NicolasHug NicolasHug deleted the windowsgpu branch September 10, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants