Switch to the standard setup-nvidia GitHub action #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 91.39% 87.35% -4.05%
==========================================
Files 30 30
Lines 2523 2523
==========================================
- Hits 2306 2204 -102
- Misses 217 319 +102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ananthsub has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ananthsub
approved these changes
Nov 10, 2022
|
@ananthsub Thank you for the review! Would you be able to merge change? The codecov check looks unrelated (may be because the PR comes from my forked repo) |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 10, 2022
Use the new [setup-nvidia](https://github.com/pytorch/test-infra/blob/main/.github/actions/setup-nvidia/action.yml) action from test-infra. The new action is created so that it can be shared across different PyTorch repos. For examples: * [pytorch/pytorch](https://github.com/pytorch/pytorch/blob/master/.github/scripts/install_nvidia_utils_linux.sh) (fixed by this PR) * [pytorch/tau](https://github.com/pytorch/tau/blob/main/.github/workflows/install_nvidia_utils_linux.sh) (fixed by pytorch/PiPPy#595) * [pytorch/torchsnapshot](https://github.com/pytorch/torchsnapshot/blob/main/.github/scripts/install_nvidia_utils_linux.sh) (fixed by meta-pytorch/torchsnapshot#130) * [torch/multiply](https://github.com/pytorch/multipy/blob/main/.github/scripts/install_nvidia_utils_linux.sh) (fixed by meta-pytorch/multipy#264) Pull Request resolved: #88757 Approved by: https://github.com/seemethere, https://github.com/atalman
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Use the new [setup-nvidia](https://github.com/pytorch/test-infra/blob/main/.github/actions/setup-nvidia/action.yml) action from test-infra. The new action is created so that it can be shared across different PyTorch repos. For examples: * [pytorch/pytorch](https://github.com/pytorch/pytorch/blob/master/.github/scripts/install_nvidia_utils_linux.sh) (fixed by this PR) * [pytorch/tau](https://github.com/pytorch/tau/blob/main/.github/workflows/install_nvidia_utils_linux.sh) (fixed by pytorch/PiPPy#595) * [pytorch/torchsnapshot](https://github.com/pytorch/torchsnapshot/blob/main/.github/scripts/install_nvidia_utils_linux.sh) (fixed by meta-pytorch/torchsnapshot#130) * [torch/multiply](https://github.com/pytorch/multipy/blob/main/.github/scripts/install_nvidia_utils_linux.sh) (fixed by meta-pytorch/multipy#264) Pull Request resolved: pytorch#88757 Approved by: https://github.com/seemethere, https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all PyTorch repos are now running on share runners as part of project Nova. We need to avoid code duplication when copying
install_nvidia_utils_linux.shand older NVIDIA driver by switching reusable setup-nvidia from test-infra repo.For the context, I'm currently seeing some NVIDIA installation failures from PyTorch where the older driver
510.60.02is used, so I'm trying to roll out this new GitHub action to avoid this: