-
Notifications
You must be signed in to change notification settings - Fork 7.2k
add initial chunk of prototype transforms #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 8788d32 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Would be good to add tests in a follow-up PR. Also, it would be instructive to implement the basic presets to see how this combines together (without AutoAugment for now for simplicity).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the import issue. LGTM.
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
* add initial chunk of prototype transforms * fix tests * add error message * fix more imports * add explicit no-ops * add test for no-ops * cleanup
Summary: * add initial chunk of prototype transforms * fix tests * add error message * fix more imports * add explicit no-ops * add test for no-ops * cleanup Reviewed By: datumbox Differential Revision: D32470491 fbshipit-source-id: 56f1c4291554842ae0166e37e955600764f563bf
This ports the initial chunk of transforms from https://github.com/pmeier/torchvision-datasets-rework/tree/rfc/transforms. You can find a discussion of this in pmeier/torchvision-datasets-rework#1.
Here is a quick demonstration:
Note to reviewers: there are two changes that make the diff look a lot larger than it is:
torchvision/prototype/transforms/presets.py
to_presets.py
in order to make it consistent with the other files there. All the changes intorchvision/prototype/models
are just fixing the imports.torchvision/prototype/datasets/utils/_internal.py
totorchvision/prototype/utils/_internal.py
. This also results in a few import changes in other files.cc @vfdev-5 @datumbox @bjuncek