Windows build scripts #1241

peterjc123 · 2019-08-14T03:13:30Z

No description provided.

codecov-io · 2019-08-14T03:27:33Z

Codecov Report

Merging #1241 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   65.84%   65.77%   -0.07%     
==========================================
  Files          75       75              
  Lines        5785     5785              
  Branches      885      885              
==========================================
- Hits         3809     3805       -4     
- Misses       1710     1713       +3     
- Partials      266      267       +1

Impacted Files	Coverage Δ
torchvision/transforms/functional.py	`70.11% <0%> (-1.15%)`	⬇️
torchvision/transforms/transforms.py	`80.98% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de158c...aad9b82. Read the comment docs.

peterjc123 · 2019-08-14T03:56:50Z

@ezyang The yaml file for Azure Pipelines is added as packaging/windows/azure-pipelines-ci.yaml.

ezyang · 2019-08-16T14:48:09Z

packaging/conda/build_vision.sh

    echo "CUDA version should be M.m with no dot, e.g. '8.0' or 'cpu'"
    exit 1
 fi
+


Heads up: this script is no longer used by the Linux/OS X binary builds (I didn't delete it because Windows still needs it), instead packaging/build_conda.sh is what is used. It would pretty awesome if we could also unify these packaging scripts, but I only really want to do it if we can keep the packaging on the shorter side. In the meantime, you can rename / simplify this script so that it is Windows only.

ezyang · 2019-08-16T14:49:12Z

packaging/torchvision/meta.yaml

    - NVCC_FLAGS
  features:
-    {{ CONDA_CPUONLY_FEATURE }}
+    {{ environ.get('CONDA_CPUONLY_FEATURE') }}


nice catch, I wonder how this ever worked lol

ezyang

I gave you commit bits so you can merge these changes directly

fmassa · 2019-09-06T15:22:16Z

@peterjc123 what's the status of this PR?

peterjc123 · 2019-09-06T15:39:30Z

It runs fine for building binaries, but for nightlies, it requires our own machines, which cannot be satisfied.

fmassa · 2019-09-09T08:55:18Z

@peterjc123 so this is a superset of the Windows improvements you did in #1298?

peterjc123 · 2019-09-09T10:02:40Z

yes, you could say that. But it was actually a different direction, which tries to do releases using Azure Pipelines, not CircleCI.

fmassa · 2019-09-09T13:11:05Z

@peterjc123 from the discussion in pytorch/pytorch#24859 (comment), what do you think about updating this patch to instead run everything on CircleCI?

cc @ezyang

peterjc123 · 2019-09-09T15:00:06Z

The problem is the limited parallelism (only 10x). @ezyang Have you talked about it with a related person?

ezyang · 2019-09-09T20:52:59Z

@peterjc123 Wait, I thought you were referring to Azure parallelism when you said we only got 10x parallelism. I can file a ticket with CircleCI to check what our Windows parallelism is, but I'm pretty sure we get more than 10x.

ezyang · 2019-09-09T20:53:20Z

You'll have to actually run the builds on PRs on these repositories, though, to get our limits.

peterjc123 · 2019-09-10T06:27:05Z

@ezyang Well, I misunderstood what @fmassa said. I was thinking that he wanted me to continue doing releases using Azure Pipelines. But actually, he needs CircleCI instead. I think it's feasible to add GPU CI for Windows. However, for releases, we may need to install some old versions of CUDA that is unsupported in CircleCI. (Windows Server 2019 is currently the only supported option for Windows on CircleCI and only CUDA 10.1 supports Windows Server 2019.) What's more, old CUDA leads to old VS and I haven't managed to install them in a Windows container. (The technology CircleCI based on)

ezyang · 2019-09-10T14:00:32Z

@soumith Do you know what our planned support window for CUDA 9.2 will be? My guess is we'd keep supporting it until CUDA 11 comes out...

Add testing yaml More Windows fixes

peterjc123 · 2019-09-15T06:07:40Z

@ezyang @fmassa The CPU and CUDA nightly build jobs are now working on Microsoft hosted agents. Do you want to enable them?

peterjc123

@ezyang Could you please upload these binaries to ossci-windows?

peterjc123 · 2019-09-15T06:11:31Z

packaging/windows/internal/cuda_install.bat

-    curl -k -L https://www.dropbox.com/s/z5b7ryz0zrimntl/cuda_9.0.176_windows.7z?dl=1 --output "%SRC_DIR%\temp_build\cuda_9.0.176_windows.7z"
+:cuda92
+if not exist "%SRC_DIR%\temp_build\cuda_9.2.148_win10.exe" (
+    curl -k -L https://developer.nvidia.com/compute/cuda/9.2/Prod2/local_installers2/cuda_9.2.148_win10 --output "%SRC_DIR%\temp_build\cuda_9.2.148_win10.exe"


peterjc123 · 2019-09-15T06:11:43Z

packaging/windows/internal/cuda_install.bat

-IF NOT EXIST "%SRC_DIR%\temp_build\cudnn-9.0-windows7-x64-v7.zip" (
-    curl -k -L https://www.dropbox.com/s/6p0xyqh472nu8m1/cudnn-9.0-windows7-x64-v7.zip?dl=1 --output "%SRC_DIR%\temp_build\cudnn-9.0-windows7-x64-v7.zip"
+if not exist "%SRC_DIR%\temp_build\cudnn-9.2-windows10-x64-v7.2.1.38.zip" (
+    curl -k -L https://downloads.sourceforge.net/project/cuda-dnn/7/CUDA-9.2/cudnn-9.2-windows10-x64-v7.2.1.38.zip --output "%SRC_DIR%\temp_build\cudnn-9.2-windows10-x64-v7.2.1.38.zip"


peterjc123 · 2019-09-15T06:11:54Z

packaging/windows/internal/cuda_install.bat

-IF NOT EXIST "%SRC_DIR%\temp_build\cuda_9.1.85_windows.7z" (
-    curl -k -L https://www.dropbox.com/s/7a4sbq0dln6v7t2/cuda_9.1.85_windows.7z?dl=1 --output "%SRC_DIR%\temp_build\cuda_9.1.85_windows.7z"
+if not exist "%SRC_DIR%\temp_build\cuda_10.0.130_411.31_win10.exe" (
+    curl -k -L https://developer.nvidia.com/compute/cuda/10.0/Prod/local_installers/cuda_10.0.130_411.31_win10 --output "%SRC_DIR%\temp_build\cuda_10.0.130_411.31_win10.exe"


peterjc123 · 2019-09-15T06:11:59Z

packaging/windows/internal/cuda_install.bat

-IF NOT EXIST "%SRC_DIR%\temp_build\cudnn-9.1-windows7-x64-v7.zip" (
-    curl -k -L https://www.dropbox.com/s/e0prhgsrbyfi4ov/cudnn-9.1-windows7-x64-v7.zip?dl=1 --output "%SRC_DIR%\temp_build\cudnn-9.1-windows7-x64-v7.zip"
+if not exist "%SRC_DIR%\temp_build\cudnn-10.0-windows10-x64-v7.4.1.5.zip" (
+    curl -k -L https://www.dropbox.com/s/9v1z9rmbjw9mhx2/cudnn-10.0-windows10-x64-v7.4.1.5.zip?dl=1 --output "%SRC_DIR%\temp_build\cudnn-10.0-windows10-x64-v7.4.1.5.zip"


peterjc123 · 2019-09-15T11:53:24Z

Future work: We can use Windows container to save time (~14 min to install VS and CUDA).

ezyang · 2019-09-16T15:13:15Z

Could you please upload these binaries to ossci-windows?

These are nightly binaries right? We should just setup automatic upload. Does Azure have a way to add private environment variables? If so, I can give you S3 creds to the nightlies bucket.

ezyang

Sure, go for it!

peterjc123 · 2019-09-16T15:47:12Z

Could you please upload these binaries to ossci-windows?

These are nightly binaries right? We should just setup automatic upload. Does Azure have a way to add private environment variables? If so, I can give you S3 creds to the nightlies bucket.

No, these are the installers of CUDA and cuDNN. According to the packer-windows scripts, they should have of the URL of https://s3.amazonaws.com/ossci-windows/win2016/******. I'll wait until these binaries are uploaded and then change the URLs in this PR.

peterjc123 · 2019-09-16T15:51:44Z

@ezyang Looks like I've uploaded these wheels by mistake, could you please remove them in https://download.pytorch.org/whl/nightly/cpu?
torchvision-0.5.0a0%2B6de158c-cp35-cp35m-win_amd64.whl
torchvision-0.5.0a0%2B6de158c-cp36-cp36m-win_amd64.whl
torchvision-0.5.0a0%2B6de158c-cp37-cp37m-win_amd64.whl

ezyang · 2019-09-17T14:43:04Z

Looks like I've uploaded these wheels by mistake, could you please remove them in https://download.pytorch.org/whl/nightly/cpu?

Done

ezyang · 2019-09-17T14:44:25Z

No, these are the installers of CUDA and cuDNN. According to the packer-windows scripts, they should have of the URL of https://s3.amazonaws.com/ossci-windows/win2016/******. I'll wait until these binaries are uploaded and then change the URLs in this PR.

I misunderstood your comment :) Working on it.

ezyang · 2019-09-17T14:55:38Z

All done!

https://ossci-windows.s3.amazonaws.com/win2016/cudnn-9.2-windows10-x64-v7.2.1.38.zip
https://ossci-windows.s3.amazonaws.com/win2016/cudnn-10.0-windows10-x64-v7.4.1.5.zip
https://ossci-windows.s3.amazonaws.com/win2016/cuda_9.2.148_win10.exe
https://ossci-windows.s3.amazonaws.com/win2016/cuda_10.0.130_411.31_win10.exe

peterjc123 · 2019-09-18T06:34:22Z

@fmassa @ezyang Nightly builds are now scheduled for Windows every night.

fmassa · 2019-09-18T13:48:07Z

Awesome, thanks a lot @peterjc123 !

peterjc123 force-pushed the win_fix branch from f097262 to 4e55fd8 Compare August 14, 2019 03:27

ezyang reviewed Aug 16, 2019

View reviewed changes

ezyang approved these changes Aug 16, 2019

View reviewed changes

peterjc123 force-pushed the win_fix branch from fe97be1 to 9ab59c4 Compare August 22, 2019 03:43

peterjc123 added 9 commits September 13, 2019 16:15

Windows build scripts

ff55ad3

Add testing yaml More Windows fixes

var name

88da673

.

20a5638

.

04e9fff

.

b8a819d

.

639de07

Change urls

f8a776b

.

8ceea35

Test MS agent

90d8cbe

peterjc123 force-pushed the win_fix branch from fd4686e to 90d8cbe Compare September 13, 2019 08:35

peterjc123 added 3 commits September 13, 2019 16:44

Switch base image

74e463c

.

3bce981

.

e40c28c

peterjc123 added 14 commits September 13, 2019 18:40

.

3e426b1

.

3622b72

.

cd66f12

.

b60e51d

.

7d2d403

.

f91cbb7

.

942004c

.

8128262

Extract before run

3e2593e

.

fa42db1

.

3a53cc4

.

52b8bf7

.

72bddbf

.

b40c983

.

5575d63

peterjc123 commented Sep 15, 2019

View reviewed changes

ezyang approved these changes Sep 16, 2019

View reviewed changes

Use fb links

aad9b82

peterjc123 merged commit 490966f into pytorch:master Sep 18, 2019

peterjc123 deleted the win_fix branch September 18, 2019 06:29

Windows build scripts #1241

Windows build scripts #1241

Uh oh!

Conversation

peterjc123 commented Aug 14, 2019

Uh oh!

codecov-io commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peterjc123 commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

ezyang Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

fmassa commented Sep 6, 2019

Uh oh!

peterjc123 commented Sep 6, 2019

Uh oh!

fmassa commented Sep 9, 2019

Uh oh!

peterjc123 commented Sep 9, 2019

Uh oh!

fmassa commented Sep 9, 2019

Uh oh!

peterjc123 commented Sep 9, 2019

Uh oh!

ezyang commented Sep 9, 2019

Uh oh!

ezyang commented Sep 9, 2019

Uh oh!

peterjc123 commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterjc123 commented Sep 15, 2019

Uh oh!

peterjc123 left a comment

Choose a reason for hiding this comment

Uh oh!

peterjc123 Sep 15, 2019

Choose a reason for hiding this comment

Uh oh!

peterjc123 Sep 15, 2019

Choose a reason for hiding this comment

Uh oh!

peterjc123 Sep 15, 2019

Choose a reason for hiding this comment

Uh oh!

peterjc123 Sep 15, 2019

Choose a reason for hiding this comment

Uh oh!

peterjc123 commented Sep 15, 2019

Uh oh!

ezyang commented Sep 16, 2019

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

peterjc123 commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterjc123 commented Sep 16, 2019

Uh oh!

ezyang commented Sep 17, 2019

Uh oh!

ezyang commented Sep 17, 2019

Uh oh!

ezyang commented Sep 17, 2019

Uh oh!

peterjc123 commented Sep 18, 2019

codecov-io commented Aug 14, 2019 •

edited

Loading

peterjc123 commented Aug 14, 2019 •

edited

Loading

peterjc123 commented Sep 10, 2019 •

edited

Loading

ezyang commented Sep 10, 2019 •

edited

Loading

peterjc123 commented Sep 16, 2019 •

edited

Loading