Skip to content

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Sep 5, 2019

Re-do of #1295, but re-using most of the packaging code that we already have. Takes into account the comments of @ezyang from #1295

The final code is much simpler as well it seems.

Tests currently are forced to run on the CPU because we currently do not have PyTorch nightly conda packages for Linux with CUDA

I still need to improve the job selection to run in master / CI

@fmassa fmassa requested review from ezyang and soumith September 5, 2019 13:34
@fmassa
Copy link
Member Author

fmassa commented Sep 5, 2019

@soumith @ezyang I have the impression that I can entirely remove https://github.com/pytorch/vision/tree/master/packaging/conda , plus the build instructions in https://github.com/pytorch/vision/blob/master/packaging/README.md seem to be deprecated.

@ezyang does this sounds about right? (for Linux and OSX at least)

@ezyang
Copy link
Contributor

ezyang commented Sep 5, 2019

@soumith @ezyang I have the impression that I can entirely remove https://github.com/pytorch/vision/tree/master/packaging/conda , plus the build instructions in https://github.com/pytorch/vision/blob/master/packaging/README.md seem to be deprecated.

It's OK for Linux and OS X; but it was previously used by Windows, unless peterjc123 has fixed the Windows pipeline.

@ezyang
Copy link
Contributor

ezyang commented Sep 5, 2019

CUDA tests via conda build is a useful thing to test for. However, I'm not sure I would have them be the only testing we do (since builds always happening inside conda build is unrealistic; it's also a pain to debug failed conda build because conda tries hard to be hermetic). This is probably fine for now, but something to keep in mind if you start having pressures to do more testing in more unusual situations.

@ezyang
Copy link
Contributor

ezyang commented Sep 5, 2019

@peterjc123 This has windows bits now. (My audio PR isn't that useful, I never got it to actually work haha)

@fmassa
Copy link
Member Author

fmassa commented Sep 5, 2019

Note that the Windows bits are not doing anything useful yet... but I'd love to be able to run some (at least CPU) tests on Windows, but I have no Windows experience

@peterjc123
Copy link
Contributor

peterjc123 commented Sep 6, 2019

@fmassa The Windows CPU build is working, but you'll have to skip some tests. Related issue: #1229.

@fmassa
Copy link
Member Author

fmassa commented Sep 6, 2019

@peterjc123 awesome, thanks a lot for all the help!

Let me know once you are done with the Windows part, I'll move your changes to config.yml.in as well, which need to be regenerated via python regenerate.py to update config.yml.

@fmassa
Copy link
Member Author

fmassa commented Sep 6, 2019

Also, I'll disable the tests for Windows that are failing, don't worry about it

@fmassa
Copy link
Member Author

fmassa commented Sep 6, 2019

@peterjc123 I have a commit ready to be pushed that disables the failing tests for Windows for now. Let me know when I can push it, to avoid potential conflicts

@peterjc123
Copy link
Contributor

@fmassa Sure, feel free to push that. Current build failure is caused by something else. (Conda base package not uploaded but cpu-only packages uploaded)

@peterjc123
Copy link
Contributor

peterjc123 commented Sep 6, 2019

Looks like the nightlies for PyTorch (Linux, CUDA, Conda) are not generated. When I run the command added in cb7a33d, it returned an empty result. @ezyang

@fmassa
Copy link
Member Author

fmassa commented Sep 6, 2019

@peterjc123 yes, that's true, and it is the cause of the failing builds that we currently have.

@peterjc123
Copy link
Contributor

peterjc123 commented Sep 6, 2019

@fmassa Now it won't fail when only part of new packages are uploaded because I introduced fine-grained search for latest PyTorch version.

@fmassa fmassa mentioned this pull request Sep 9, 2019
@fmassa fmassa marked this pull request as ready for review September 9, 2019 09:06
@fmassa fmassa changed the title [WIP] Add CircleCI (v2) Add CircleCI (v2) Sep 9, 2019
@fmassa fmassa merged commit e4d5003 into pytorch:master Sep 9, 2019
@fmassa fmassa deleted the add-circleci-newtry branch September 9, 2019 09:48
This was referenced Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants