Fix bug of changing input tensor in utils.save_image #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code will change the image tensor passed in by multiplying it by 255. The PR fixes that.
|
related to #1206 |
pmeier
requested changes
Aug 16, 2019
torchvision/utils.py
Outdated
| **kwargs: Other arguments are documented in ``make_grid``. | ||
| """ | ||
| from PIL import Image | ||
| tensor = tensor.clone() |
There was a problem hiding this comment.
Instead of cloning the tensor, I agree with @fmassa that replacing the in-place operations is the better choice here, since it is unclear why they are used in the first place.
There was a problem hiding this comment.
I see, let me change the PR
buoyancy99
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 65.64% 65.09% -0.55%
==========================================
Files 74 74
Lines 5784 5785 +1
Branches 884 884
==========================================
- Hits 3797 3766 -31
- Misses 1723 1741 +18
- Partials 264 278 +14
Continue to review full report at Codecov.
|
pmeier
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code of torchvision.utils.save_image will change the image tensor passed in by multiplying it by 255. The PR fixes that.
Sample code to reproduce the bug:
import torch
from torchvision.utils import save_image
img = torch.ones((5, 3, 64, 64))
save_image(img[0], 'dummy.jpg')
print(torch.max(img))