CPU implementation for Position-sensitive ROI Pool/Align #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f this layer is no texecuted
fmassa
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Thanks for the PR and the CPU implementation!
There are conflicts in this PR that should be addressed before we can merge this.
We have now moved away from the pybind11 approach in favor of torch ops, and we now declare autograd via C++ and not torch.autograd.Function anymore, see #1314 and #1348 for some more context.
|
I'll take a look at this tomorrow. Wasn't aware of the fact that this had changed in the meanwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements CPU fallback for PSROIPool and PSROIAlign layers based on their CUDA versions implemented in PR #1259.
See also the related discussion.