-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Position-sensitive ROI Pool/Align #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ce3e62d
to
9efd51c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 65.89% 65.14% -0.75%
==========================================
Files 75 76 +1
Lines 5785 5876 +91
Branches 885 886 +1
==========================================
+ Hits 3812 3828 +16
- Misses 1708 1783 +75
Partials 265 265
Continue to review full report at Codecov.
|
I'm already using the layer and it works fine! |
I will get this reviewed and merged into torchvision soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
torchvision requires the ops to be implemented on both CPU and GPU (with a potential fallback to CPU in some particular cases, but CPU implementation is a must).
So this PR can't be merged in it's current state unfortunately.
AT_ERROR("Not compiled with GPU support"); | ||
#endif | ||
} | ||
AT_ERROR("Not implemented on the CPU"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torchvision follows similar requirements as PyTorch with respect to the implementation of the ops: it requires the ops to be implemented for both CPU and GPU.
@sampepose Are you working on this? Or should I give it a try? |
I'm currently working on the CPU implementation as I rely on this layer for another project. |
This has been subsumed by #1410. Thanks for the original version @sampepose! |
This adds PS ROI pool and align. I also fixed a couple bugs with existing ROI pool tests.