Skip to content

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Oct 17, 2019

CUDA builds on Windows were failing after #1410 was merged, with errors like

D:/_work/1/s/packaging/windows/vision/torchvision/csrc/cuda/PSROIAlign_cuda.cu(339): error: no instance of function template "at::cuda::ATenCeilDiv" matches the argument list
              argument types are: (int64_t, long)
  
  D:/_work/1/s/packaging/windows/vision/torchvision/csrc/cuda/PSROIAlign_cuda.cu(339): error: no instance of overloaded function "std::min" matches the argument list
              argument types are: (<error-type>, long)
  
  D:/_work/1/s/packaging/windows/vision/torchvision/csrc/cuda/PSROIAlign_cuda.cu(398): error: no instance of function template "at::cuda::ATenCeilDiv" matches the argument list
              argument types are: (int64_t, long)
  
  D:/_work/1/s/packaging/windows/vision/torchvision/csrc/cuda/PSROIAlign_cuda.cu(398): error: no instance of overloaded function "std::min" matches the argument list
              argument types are: (<error-type>, long)

see https://dev.azure.com/pytorch/PyTorch/_build/results?buildId=17560 for the full logs.

This PR fix it following an approach similar to #953

@fmassa fmassa requested a review from peterjc123 October 17, 2019 08:06
Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #1484. LGTM

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #1485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files          83       83           
  Lines        6421     6421           
  Branches      982      982           
=======================================
  Hits         4139     4139           
  Misses       1992     1992           
  Partials      290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b062c...15f097e. Read the comment docs.

@fmassa fmassa merged commit 7b5075f into pytorch:master Oct 17, 2019
@fmassa fmassa deleted the fix-cuda-ps-roi branch October 17, 2019 08:32
facebook-github-bot pushed a commit to facebookresearch/detectron2 that referenced this pull request Feb 11, 2020
Summary:
Fix for #848 (comment)
Followed solution from pytorch/vision#1485

And the build successfully done.
Pull Request resolved: #849

Differential Revision: D19839507

Pulled By: ppwwyyxx

fbshipit-source-id: 6f6d5cbe3c318ad9626e82db17fa86489c10347b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants