Fix windows build #953
Merged
Fix windows build #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSBuild Compile time casting Error
MSBuild Error static_cast<Long> to static_cast<int64_t>
Not Work find_contours
|
cc @soumith |
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 60.15% 60.15%
=======================================
Files 63 63
Lines 5019 5019
Branches 748 748
=======================================
Hits 3019 3019
Misses 1796 1796
Partials 204 204Continue to review full report at Codecov.
|
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
May 23, 2019
* pytorch#944 MSBuild Compile time casting Error * pytorch#944 MSBuild Error static_cast<Long> to static_cast<int64_t> * Add eval.py Not Work find_contours * Remove unnecessary file * Lint
fmassa
added a commit
that referenced
this pull request
May 23, 2019
|
@fmassa now that this is fixed when is the windows pip release coming for 0.3.0? |
|
@TheCodez Windows wheels are already available, right? I think they are already live. cc @peterjc123 |
|
@fmassa I tried it today and the latest was 0.2.2.post3 |
|
Isn't this one working? |
|
@TheCodez Should be fixed now. Please try the installation steps on https://pytorch.org. |
|
Thanks, it's working now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR and fixes from #951 by @kerry-Cho, with the linter added.
Thanks a lot @kerry-Cho for the fixes!