Fix broken bitwise operation in Similarity Reference loss #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 90 90
Lines 7085 7085
Branches 1075 1075
=======================================
Hits 4652 4652
Misses 2126 2126
Partials 307 307Continue to review full report at Codecov.
|
|
No worries 👍 |
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Dec 18, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
Summary: Pull Request resolved: #1679 Reviewed By: cpuhrsch Differential Revision: D19156833 Pulled By: fmassa fbshipit-source-id: 77165540505982c3677e1b74f97c94c5cbc35b8f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried running the similarity reference with pytorch 1.3.1 and torchvision 0.4.2 but got an error on line 94 and 105 saying,
, where the operations are between a byte tensor and a bool tensor. Fixed by changing all of the masking code to just use bool tensors.