Skip to content

Fix broken bitwise operation in Similarity Reference loss #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix broken bitwise operation in Similarity Reference loss #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions references/similarity/loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def batch_all_triplet_loss(labels, embeddings, margin, p):

def _get_triplet_mask(labels):
# Check that i, j and k are distinct
indices_equal = torch.eye(labels.size(0), dtype=torch.uint8, device=labels.device)
indices_equal = torch.eye(labels.size(0), dtype=torch.bool, device=labels.device)
indices_not_equal = ~indices_equal
i_not_equal_j = indices_not_equal.unsqueeze(2)
i_not_equal_k = indices_not_equal.unsqueeze(1)
Expand All @@ -96,7 +96,7 @@ def _get_triplet_mask(labels):

def _get_anchor_positive_triplet_mask(labels):
# Check that i and j are distinct
indices_equal = torch.eye(labels.size(0), dtype=torch.uint8, device=labels.device)
indices_equal = torch.eye(labels.size(0), dtype=torch.bool, device=labels.device)
indices_not_equal = ~indices_equal

# Check if labels[i] == labels[j]
Expand Down