Skip to content

Fixes types annotation #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Fixes types annotation #3057

wants to merge 7 commits into from

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented Nov 30, 2020 •
edited
Loading

Due to torchscript support torch.device now, I updated the Device to torch.device. And I added a missing Optional statement in retinanet modules.

@zhiqwang
Copy link
Contributor Author

Hi, It's unexpected that the modification of type Device to torch.device would affect a lot in the unittest, so I closed it );

@zhiqwang zhiqwang closed this Nov 30, 2020
@datumbox datumbox mentioned this pull request Nov 30, 2020
Merged
@datumbox
Copy link
Contributor

Unfortunately I did not have the rights to push on your branch to fix the error, so I pushed your changes on a separate PR at #3059.

@zhiqwang zhiqwang deleted the fix_type branch May 8, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiqwang @datumbox @facebook-github-bot