Fixes types annotation #3059
Merged
Fixes types annotation #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fmassa
approved these changes
Nov 30, 2020
| import torch.nn as nn | ||
| from torch import Tensor | ||
| from torch.jit.annotations import Dict, List, Tuple | ||
| from torch.jit.annotations import Dict, List, Tuple, Optional |
There was a problem hiding this comment.
It is used in here
There was a problem hiding this comment.
Ok. Let's keep this here then, as when we move the # type: annotations to be inline the import will be necessary
This was referenced Nov 30, 2020
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Correcting incorrect types * Add missing type statement * Fix type annotations in unittest * Fix TypeError * Fix TypeError * Fix type equality judgment * Fix recursive compile * Use string for class name annotation. Co-authored-by: zhiqiang <zhiqwang@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the work of @zhiqwang at #3057
Just made a few minor changes to avoid the postponed evaluation of annotations.