Improved image extension robustness #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_image_file is now case insensitive Added docstring to is_image_file is_image_file now returns true for pgm files
alykhantejani
approved these changes
Nov 6, 2017
| bool: True if the filename ends with a known image extension | ||
| """ | ||
| filename_lower = filename.lower() | ||
| return any(filename_lower.endswith(ext) for ext in IMG_EXTENSIONS) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
thanks @Erotemic ! |
rajveerb
pushed a commit
to rajveerb/vision
that referenced
this pull request
Nov 30, 2023
…daries (pytorch#322) * [single_stage_detector] Dockerfile copy sources after pip install * [single_stage_detector] epoch based evaluation, warmup and lr decay resolves issues pytorch#290 and mlperf/training_policies/pytorch#210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with loading pgm images when using the ATT Faces dataset. The
.pgmextension was missing fromIMG_EXTENSIONS. As far as I know, PIL can read this format without any trouble, so it should be safe to add. Let me know if I'm wrong about this.While I was there, I noticed all the extensions were duplicated for caps and lower case, so I made them all lowercase in the variable and changed
is_image_fileto transform the input string into lower case. This adds robustness to weird corner cases likeimg.Jpeg.Lastly, I added a docstring.