Skip test if connection issues on fate #4284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Aug 17, 2021
| video_path = fate("sub/MovText_capability_tester.mp4", VIDEO_DIR) | ||
| try: | ||
| video_path = fate("sub/MovText_capability_tester.mp4", VIDEO_DIR) | ||
| except (urllib.error.URLError, ConnectionError) as error: |
There was a problem hiding this comment.
Could you please add a TODO or a FIXME comment so we remember to remove this eventually? Otherwise LGTM, thanks
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Summary: * Skip the test if the failure is due to a connection error. * Add todo. Reviewed By: NicolasHug Differential Revision: D30417199 fbshipit-source-id: 4aa7f22ed1debf1fd0b0f674775ca74fa0197043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fate server of FFmpeg has been giving us headaches the last 2 weeks. Instead of disabling temporarily the test, I'm taking the approach to skip it if a connection issue occurs.
cc @pmeier