Skip to content

Skip test if connection issues on fate #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Skip test if connection issues on fate #4284

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4632c8d
Skip the test if the failure is due to a connection error.
datumbox Aug 17, 2021
12f9302
Merge branch 'master' into tests/skip_on_connection_error
datumbox Aug 17, 2021
77460f3
Add todo.
datumbox Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/test_videoapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import os
import pytest
from pytest import approx
import urllib

import torch
import torchvision
Expand Down Expand Up @@ -177,7 +178,11 @@ def test_accurateseek_middle(self):
assert (lb <= frame["pts"]) and (ub >= frame["pts"])

def test_fate_suite(self):
video_path = fate("sub/MovText_capability_tester.mp4", VIDEO_DIR)
# TODO: remove the try-except statement once the connectivity issues are resolved
try:
video_path = fate("sub/MovText_capability_tester.mp4", VIDEO_DIR)
except (urllib.error.URLError, ConnectionError) as error:
Copy link
Member

@NicolasHug NicolasHug Aug 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a TODO or a FIXME comment so we remember to remove this eventually? Otherwise LGTM, thanks

pytest.skip(f"Skipping due to connectivity issues: {error}")
vr = VideoReader(video_path)
metadata = vr.get_metadata()

Expand Down