Use FX feature extractor for segm model #4563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vfdev-5 Thanks for the PR. Adding the extra parameter will introduce twice as many tests for each model which will slow things down. As discussed at #4540 (comment), which solution we use to extract the features seems an internal detail for the models that we can easily adapt if the FX requires changes. Moreover given that the module |
vfdev-5
force-pushed
the
segm-model-with-fe
branch
from
94bf3bb to
21b0ff8
Compare
|
@datumbox OK, sounds good to remove |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Summary: * Use FX feature extractor for segm model * Removed use_fe option Reviewed By: NicolasHug Differential Revision: D31505556 fbshipit-source-id: ff7b12aabab5363dd0ae10a03aaf008e7497946e
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* Use FX feature extractor for segm model * Removed use_fe option
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Use FX feature extractor for segm model * Removed use_fe option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related to #4540
cc @datumbox