Temporarily use IntermediateLayerGetter on segmentation #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit ef7c337 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
changed the title
datumbox
force-pushed
the
segmentation/intermedia_layer
branch
from
6a06466 to
160e564
Compare
datumbox
added
the
other
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: Temporarily use IntermediateLayerGetter on segmentation Reviewed By: kazhang Differential Revision: D33927491 fbshipit-source-id: 0151785c51d1ed15626bd3f09e5aec4d9fdbb6d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to revert #4563 and temporarily switch to IntermediateLayerGetter prior the upcoming feature cut. This will give us a bit more time to test PyTorch FX and ensure that both Detection and Segmentation use the same solution. There is already a ticket for the latter at #4540, so we can keep it open to keep track of the work.