Applied contiguous in decode_* ops
#4898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Applied `contiguous` on decoded output tensor in decode_jpeg and decode_png ops - Updated tests and docs Related to pytorch#4880
💊 CI failures summary and remediationsAs of commit 0ec7ce2 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
|
@NicolasHug Do you think it's worth adding |
|
I would just add enhancement + perf |
|
This was here on purpose for speed improvements on the reading (avoids copy). I would revert this PR, and work on improving the performance on the transforms instead so that they better handle channel_last format |
vfdev-5
added a commit
that referenced
this pull request
Nov 10, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Description: - Applied `contiguous` on decoded output tensor in decode_jpeg and decode_png ops - Updated tests and docs Related to pytorch#4880
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
Summary: Description: - Applied `contiguous` on decoded output tensor in decode_jpeg and decode_png ops - Updated tests and docs Related to #4880 Reviewed By: datumbox Differential Revision: D32470473 fbshipit-source-id: 83ba2e1fccbfb414c66c1c6da7e516990aa7225f
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
contiguouson decoded output tensor in decode_jpeg and decode_png opsRelated to #4880
Performance improvement on following transforms, see #4880 (comment)