Skip to content

Revert "Applied contiguous in decode_* ops" #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2021
Merged

Revert "Applied contiguous in decode_* ops" #4901

merged 1 commit into from
Nov 10, 2021

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 10, 2021

Reverts #4898

Due to #4898 (comment)

We have to make sure that channels_last is properly taken into account

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 10, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4faaf7a (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_libtorchvision_ops_android Build 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@vfdev-5 vfdev-5 mentioned this pull request Nov 10, 2021
Open
@vfdev-5 vfdev-5 merged commit 57e6e30 into main Nov 10, 2021
@vfdev-5 vfdev-5 deleted the revert-4898-fix-decode-noncontig branch November 10, 2021 14:20
@github-actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox added module: io revert(ed) For reverted PRs, and PRs that revert other PRs labels Nov 10, 2021
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@vfdev-5 @cyyever
Revert "decode_* returns contiguous tensors (pytorch#4898)" (pytorch#…
a692607 
…4901)

This reverts commit 85b7858.
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
@kazhang @facebook-github-bot
[fbsync] Revert "decode_* returns contiguous tensors (#4898)" (#4901)
dfca069 
Summary: This reverts commit 85b7858.

Reviewed By: datumbox

Differential Revision: D32470470

fbshipit-source-id: 1d9f5ec918ac8b58f9f360a147d0c76298058ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: io revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @facebook-github-bot @fmassa @datumbox