Skip to content

Conversation

developer0hye
Copy link
Contributor

# degenerate boxes gives inf / nan results
# so do an early check
if (boxes1[:, 2:] < boxes1[:, :2]).any():
raise ValueError("Some of the input boxes1 are invalid.")
if not (boxes2[:, 2:] >= boxes2[:, :2]).all():
raise ValueError("Some of the input boxes2 are invalid.")

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 26, 2022

💊 CI failures summary and remediations

As of commit 0af1703 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox
Copy link
Contributor

datumbox commented Mar 26, 2022

@developer0hye Thanks for the contribution. Unfortunately adding these assertions means a significant slowdown. If you check git blame you will actually see that originally we had assertions and we removed them to improve speed. If you need them then we advise to wrap the loss in your own method and add the assertions there.

@datumbox datumbox closed this Mar 26, 2022
@developer0hye developer0hye deleted the patch-4 branch March 27, 2022 03:03
@developer0hye
Copy link
Contributor Author

@datumbox
Thanks for your review!

I also think that it makes this function slow. However, I am still curious about that adding this condition makes whole training process slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants