Skip to content

add positional exception for giou loss #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add positional exception for giou loss #5684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5343f0
add positional exception for giou loss
developer0hye Mar 26, 2022
0af1703
clang
developer0hye Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions torchvision/ops/giou_loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ def generalized_box_iou_loss(
x1, y1, x2, y2 = boxes1.unbind(dim=-1)
x1g, y1g, x2g, y2g = boxes2.unbind(dim=-1)

# degenerate boxes gives inf / nan results
# so do an early check
if not ((x2 >= x1) & (y2 >= y1)).all():
raise ValueError("Some of the input boxes1 are invalid.")
if not ((x2g >= x1g) & (y2g >= y1g)).all():
raise ValueError("Some of the input boxes2 are invalid.")

# Intersection keypoints
xkis1 = torch.max(x1, x1g)
ykis1 = torch.max(y1, y1g)
Expand Down