Clarify TypeError message #5994
Conversation
|
Hi @Gouvernathor! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Looks like mypy's unhappy, https://app.circleci.com/pipelines/github/pytorch/vision/17503/workflows/2278000d-f2f2-419d-8426-561e3652aa1e/jobs/1417103 Could you have a look @Gouvernathor please? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Yeah, I need to wrap the type() in a repr() so it shuts up (even though the f-string formatting does it by itself). |
so that the type-check stfu
|
Please consider 5447 before this one, I find it better. |
|
superseded by #5997 |
To have a more clearer message than
TypeError: tensor or list of tensors expected, got <class 'list'>, when having (for example) a list of numpy arrays.Even better would be to parse the list and return the type of the first non-tensor. If you don't mind the code difference, I'll program that.