Clarify TypeError message #5997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the type-check stfu
incidentally speeds up the thing, since all() possibly checked all elements and we don't.
datumbox
changed the title
datumbox
approved these changes
May 12, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
May 24, 2022
Summary: * Clarify TypeError message * typo * Wrap tye() in repr() so that the type-check stfu * Even better message incidentally speeds up the thing, since all() possibly checked all elements and we don't. Reviewed By: datumbox Differential Revision: D36413347 fbshipit-source-id: ddd904bcd3b5b433a76e44cea949e809434b914a Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a clearer message than
TypeError: tensor or list of tensors expected, got <class 'list'>, when having (for example) a list of numpy arrays.