Skip to content

Conversation

SvenDS9
Copy link
Contributor

@SvenDS9 SvenDS9 commented Mar 9, 2023

Fixes #7201, use binomtest instead of binom_test as the former is deprecated

cc @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/7404

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to torchvision @SvenDS9 and thanks for the PR! I've checked that the deprecation warning is no longer popping up. The CI failures are unrelated.

@pmeier pmeier merged commit 6218dc3 into pytorch:main Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@SvenDS9 SvenDS9 deleted the binomtest branch March 9, 2023 17:09
facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Reviewed By: vmoens

Differential Revision: D44416616

fbshipit-source-id: 4251798d5163669c73b1a5d65ae96eba34f528b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of scipy.stats.binom_test

3 participants